Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup broken contract deployments #370

Closed
wants to merge 5 commits into from

Conversation

paulperegud
Copy link
Contributor

Recent merge #345 broken contract deployments. This PR is a fix.

* `clean` no longer kills all of docker, just its own containers.
* change name to reflect new behavior
@paulperegud paulperegud added the request-approval Request approval from the Housekeeper label Jul 31, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 31, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10177310537 failed 💥

@paulperegud paulperegud force-pushed the fixup-broken-contract-deployments branch from d3087d9 to 7419f99 Compare July 31, 2024 11:42
@paulperegud paulperegud added the request-approval Request approval from the Housekeeper label Jul 31, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 31, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10179540822 failed 💥

@paulperegud
Copy link
Contributor Author

Closing this one. Its commits are a part of #367 now, which will be easier to put through CI, since better /info/sync-status behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants