OCT-1596 Implement automated sanity tests for Info API section #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziolek
changed the title
aziolek
reviewed
Jul 19, 2024
There was a problem hiding this comment.
@MateuszStoleckiGLM: maybe rebase to master? There is nothing in BE in develop that is not in master, more tests == better and one thing less in the next develop => master release is always a good thing.
MateuszStoleckiGLM
force-pushed
the
feature/OCT-1596-info-api-sanity-test
branch
2 times, most recently
from
58bd108
to
0dcbf1f
Compare
MateuszStoleckiGLM
force-pushed
the
feature/OCT-1596-info-api-sanity-test
branch
from
0dcbf1f
to
a6dfce2
Compare
kgarbacinski
previously approved these changes
Jul 24, 2024
Signed-off-by: Mateusz Stolecki <mateusz@golem.foundation>
Signed-off-by: Mateusz Stolecki <mateusz@golem.foundation>
Signed-off-by: Mateusz Stolecki <mateusz@golem.foundation>
Signed-off-by: Mateusz Stolecki <mateusz@golem.foundation>
paulperegud
force-pushed
the
feature/OCT-1596-info-api-sanity-test
branch
from
972561f
to
1730cc5
Compare
multideployer: * non-zero exit on subcommand => http 500 * print stdout and stderr in logs * return stdout and stderr as a text accompanying the http 500 conftest: * if multideployer crashes, log the details
paulperegud
force-pushed
the
feature/OCT-1596-info-api-sanity-test
branch
from
8e93b91
to
48c02ea
Compare
housekeeper-bot
removed
the
request-approval
housekeeper-bot
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done
(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.
(2) Octant Areas & Test Cases.