Skip to content

Commit

Permalink
Add Firefox to should unlock list
Browse files Browse the repository at this point in the history
Fixes #1166
  • Loading branch information
goldfire committed Apr 19, 2019
1 parent 567520b commit 9eac9d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/howler.core.js
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
var self = this || Howler;

// Only run this on certain browsers/devices.
var shouldUnlock = /iPhone|iPad|iPod|Android|BlackBerry|BB10|Silk|Mobi|Chrome|Safari/i.test(self._navigator && self._navigator.userAgent);
var shouldUnlock = /iPhone|iPad|iPod|Android|BlackBerry|BB10|Silk|Mobi|Chrome|Safari|Firefox/i.test(self._navigator && self._navigator.userAgent);
if (self._audioUnlocked || !self.ctx || !shouldUnlock) {
return;
}
Expand Down

2 comments on commit 9eac9d9

@obiot
Copy link
Contributor

@obiot obiot commented on 9eac9d9 Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not basically all browsers now ?

@goldfire
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly...yes. Probably makes sense to get rid of this, but I'll do some testing in IE first to make sure there are no issues.

Please sign in to comment.