Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox now blocks automatically playing audio too #1166

Closed
chris-bingham opened this issue Apr 17, 2019 · 2 comments
Closed

Firefox now blocks automatically playing audio too #1166

chris-bingham opened this issue Apr 17, 2019 · 2 comments

Comments

@chris-bingham
Copy link

As of version 66, firefox is now the latest browser to block automatically playing audio
See https://hacks.mozilla.org/2019/02/firefox-66-to-block-automatically-playing-audible-video-and-audio/

Can we get FF added to the shouldUnlock regex test string, line 286 of src/howler.core.js?

Happy to open a PR but dont have permission to push to the repo

@themoonrat
Copy link
Contributor

@goldfire at this point, is there any harm in this just always running rather than a regex test? At this point, it's only IE and Edge that don't require it, and Edge soon will when it starts using Chromium.

@goldfire
Copy link
Owner

I started to do some IE testing and then realized there is no need since it skips IE anyway due to lack of Web Audio. I've removed that check completely in 5f4c37e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants