fix: gc works unexpeted in high concurrent #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
reviewed
Aug 24, 2023
imeoer
reviewed
Aug 24, 2023
We can try |
When acceld converts multiple images with large size differences, for example : alpine and WordPress. Obviously alpine will finish the task first, and WordPress is still in the pulling phase. If alpine triggers gc(decide by configuration), GC will clear the blobs of WordPress, because the lease of WordPress blob had cached in lease and only used once(in commit). To solve this problem, now gc will wait all converting tasks completed. fix goharbor#174 Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
fix-gc-concurrent
branch
from
4e042aa to
f889840
Compare
imeoer
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the concurrent race issue, now gc will wait for all converting tasks completed.
resolve #174.