-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: gc clear blobs unexpeted #174
Comments
Desiki-high
added a commit
to Desiki-high/acceleration-service
that referenced
this issue
Aug 23, 2023
When acceld converts multiple images with large size differences, for example : alpine and WordPress. Obviously alpine will finish the task first, and WordPress is still in the pulling phase. If alpine triggers gc(decide by configuration), GC will clear the blobs of WordPress, because the lease of WordPress blob had cached in lease and only used once(in commit). To solve this problem, now gc will wait all converting tasks completed. fix goharbor#174 Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
added a commit
to Desiki-high/acceleration-service
that referenced
this issue
Aug 23, 2023
When acceld converts multiple images with large size differences, for example : alpine and WordPress. Obviously alpine will finish the task first, and WordPress is still in the pulling phase. If alpine triggers gc(decide by configuration), GC will clear the blobs of WordPress, because the lease of WordPress blob had cached in lease and only used once(in commit). To solve this problem, now gc will wait all converting tasks completed. fix goharbor#174 Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
added a commit
to Desiki-high/acceleration-service
that referenced
this issue
Aug 24, 2023
When acceld converts multiple images with large size differences, for example : alpine and WordPress. Obviously alpine will finish the task first, and WordPress is still in the pulling phase. If alpine triggers gc(decide by configuration), GC will clear the blobs of WordPress, because the lease of WordPress blob had cached in lease and only used once(in commit). To solve this problem, now gc will wait all converting tasks completed. fix goharbor#174 Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Gc will clear blobs by lease manager, lease manager will clear lease by lease cache. Lease will be updated in
commit
andread
of each blob.When
acceld
work in multithread conversion with different jobs, some task can not find the blob locally.Reproduce
acceld
.accelctl
create different tasks.Reason
When acceld converts multiple images with large size differences, for example :
alpine
andWordPress
. Obviouslyalpine
will finish the task first, andWordPress
is still in the pulling phase. Ifalpine
triggers gc(decide by configuration), GC will clear the blobs ofWordPress
because the lease ofWordPress
blob had cached in lease and only used once(in commit).The text was updated successfully, but these errors were encountered: