nydus: fix oci media type handle #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
fix-image-history
branch
from
dee89c1 to
7148442
Compare
Bump nydus snapshotter v0.7.3 and bring some fixups: 1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type. 2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136 Related PR: containerd/nydus-snapshotter#427 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
fix-image-history
branch
from
7148442 to
4065a63
Compare
liubogithub
approved these changes
Mar 21, 2023
|
Looks good to me. |
imeoer
added a commit
to imeoer/image-service
that referenced
this pull request
Mar 21, 2023
Bump nydus snapshotter v0.7.3 and bring some fixups: 1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type. 2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136 Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Mar 23, 2023
Bump nydus snapshotter v0.7.3 and bring some fixups: 1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type. 2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136 Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Mar 23, 2023
Bump nydus snapshotter v0.7.3 and bring some fixups: 1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type. 2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136 Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
ccx1024cc
pushed a commit
to ccx1024cc/image-service
that referenced
this pull request
Mar 23, 2023
Bump nydus snapshotter v0.7.3 and bring some fixups: 1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type. 2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136 Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
hangvane
pushed a commit
to hangvane/image-service
that referenced
this pull request
Apr 7, 2023
Bump nydus snapshotter v0.7.3 and bring some fixups: 1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type. 2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136 Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump nydus snapshotter v0.7.3 and bring some fixups:
Related PR: containerd/nydus-snapshotter#427