Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converter: fix image history handle #427

Merged
merged 1 commit into from
Mar 21, 2023
Merged

converter: fix image history handle #427

merged 1 commit into from
Mar 21, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Mar 20, 2023

  1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
  2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

@imeoer
converter: fix image history handle
e9e2ad1 
1. If the original image is already an OCI type, we should forcibly set the
   bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history
   consistency, see:
   https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer imeoer changed the title [WIP] converter: fix image history handle [v1.7.2] converter: fix image history handle Mar 20, 2023
@changweige changweige merged commit 7ee5ff2 into containerd:main Mar 21, 2023
imeoer added a commit to imeoer/acceleration-service that referenced this pull request Mar 21, 2023
@imeoer
nydus: fix oci media type handle
dee89c1 
Bump nydus snapshotter v0.7.2 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer imeoer mentioned this pull request Mar 21, 2023
Merged
imeoer added a commit to imeoer/acceleration-service that referenced this pull request Mar 21, 2023
@imeoer
nydus: fix oci media type handle
7148442 
Bump nydus snapshotter v0.7.2 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer added a commit to imeoer/acceleration-service that referenced this pull request Mar 21, 2023
@imeoer
nydus: fix oci media type handle
4065a63 
Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer imeoer changed the title [v1.7.2] converter: fix image history handle converter: fix image history handle Mar 21, 2023
imeoer added a commit to imeoer/image-service that referenced this pull request Mar 21, 2023
@imeoer
nydusify: fix oci media type handle
dac61cc 
Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer imeoer mentioned this pull request Mar 21, 2023
Merged
ccx1024cc pushed a commit to ccx1024cc/image-service that referenced this pull request Mar 23, 2023
@imeoer
nydusify: fix oci media type handle
ffbd47e 
Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
ccx1024cc pushed a commit to ccx1024cc/image-service that referenced this pull request Mar 23, 2023
@imeoer
nydusify: fix oci media type handle
1590d86 
Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
ccx1024cc pushed a commit to ccx1024cc/image-service that referenced this pull request Mar 23, 2023
@imeoer
nydusify: fix oci media type handle
009443b 
Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
hangvane pushed a commit to hangvane/image-service that referenced this pull request Apr 7, 2023
@imeoer @hangvane
nydusify: fix oci media type handle
b6c3810 
Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changweige changweige changweige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imeoer @changweige