Fix AnimationLibrary loading #96577
Merged
Fix AnimationLibrary loading #96577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 4, 2024
timothyqiu
approved these changes
Sep 5, 2024
rune-scape
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
this .. shouldn't be the case, dictionaries use a hashmap defined with StringLikeVariantComparator, so
converting a String key to StringName, then getting the value for that StringName should always work like expected in GDScript.
id like to find the root bug, but it seems to fix the issue
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96553
Seems like the String/StringName key unification only applies to GDScript, raw Dictionaries still differentiate between the two.
Dictionary access uses Variant anyway, so using converted key was pointless. The Variant passed to
add_animation_library()is converted implicitly. It doesn't matter if it's stored in a variable or not.