Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation lost when opening projects created in 4.3 #96553

Closed
timothyqiu opened this issue Sep 4, 2024 · 2 comments · Fixed by #96577 or #96586
Closed

Animation lost when opening projects created in 4.3 #96553

timothyqiu opened this issue Sep 4, 2024 · 2 comments · Fixed by #96577 or #96586

Comments

@timothyqiu
Copy link
Member

Tested versions

  • Reproducible: master[e2dd56b]
  • Not reproducible: 4.4.dev1

System information

Arch Linux

Issue description

When opening a project created in 4.3, animations in AnimationPlayers are lost with this error:

ERROR: Condition "p_animation_library.is_null()" is true. Returning: ERR_INVALID_PARAMETER
   at: add_animation_library (scene/animation/animation_mixer.cpp:281)

Probably an regression from #70096

Steps to reproduce

  • Create a project in 4.3, add an AnimationPlayer in the scene and create a new Animation in it.
  • Open the project with an editor built from master.

Minimal reproduction project (MRP)

test.zip

@akien-mga
Copy link
Member

Probably an regression from #70096

Confirmed, a local revert of that PR solves the issue (on top of 906a4e9).

CC @rune-scape @godotengine/core @godotengine/animation

@rune-scape
Copy link
Contributor

the underlying issue is that the hash for an empty String is different than the hash for an empty StringName
and the default animation library is an empty string
so when the String key is converted to a StringName, it hashes differently
making a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Immediate Blocker
Development

Successfully merging a pull request may close this issue.

3 participants