Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some SpotLight3D issues (clustering artifacts, leaking light, AABB) #71832

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Geometror
Copy link
Member

Before
Godot_v4 0-beta14_win64_nSIGPu2u3W

With this PR
0nhWuPqzLZ

@Geometror Geometror added this to the 4.0 milestone Jan 22, 2023
@Geometror Geometror requested review from a team as code owners January 22, 2023 03:25
@Geometror Geometror changed the title Fix some SpotLight3D issues (clustering artifacts, leaking light) Fix some SpotLight3D issues (clustering artifacts, leaking light, AABB) Jan 22, 2023
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little style nitpick. Otherwise the PR looks good!

Tested locally using an Nvidia GPU which could reproduce the listed issues. This PR fixes the issues

servers/rendering/renderer_rd/cluster_builder_rd.h Outdated Show resolved Hide resolved
@Geometror Geometror force-pushed the fix-spotlight-artifacts branch from c187566 to 4bd01a9 Compare January 24, 2023 00:09
@akien-mga akien-mga merged commit a6042b6 into godotengine:master Jan 24, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment