Rename str2var to str_to_var and similar

[Mickeon]

Closes godotengine/godot-proposals#5206.

As brought up in #54161 (comment).

To make it short, the naming scheme with "2" in the middle is not always used across Godot (String.int_to_bin()), and it isn't proper English.

Affects the internal Math class, a good chunk of the audio filter code, and a lot of miscellaneous classes.

Before	After
var2str	var_to_str
str2var	str_to_var
bytes2var	bytes_to_var
bytes2var_with_objects	bytes_to_var_with_objects
var2bytes	var_to_bytes
var2bytes_with_objects	var_to_bytes_with_objects
linear2db	linear_to_db
db2linear	db_to_linear
deg2rad	deg_to_rad
rad2deg	rad_to_deg

Added later in this PR:

Before	After
dict2inst	dict_to_inst
inst2dict	inst_to_dict

I think it's worth noting, before merging this, that while testing I did find writing these methods to be much slower (underscore, two characters, another underscore, and the Italian keyboard requires holding Shift to access the underscores), although it may be a matter of getting used to it.

[raulsntos]

The .po and .pot files in the doc/translations/ folder are auto-generated when syncing translations from Weblate, you should not manually change them.

[fire]

@Calinou Thoughts on this? I support this rename of 2 to "to".

[Mickeon]

The mentioned reply is among the most liked in the tracker.

[TokageItLab]

Doesn't deg2rad/rad2deg also need to be changed?

[Mickeon]

Oopsie. Will update as soon as possible.

[Mickeon]

Updated to include deg_to_rad and rad_to_deg.

[YuriSizov]

The last time this was discussed, we didn't decide how far the naming change should go. For example, with these changes it no longer makes sense to use shortened terms, e.g. str instead of string, deg instead of degree.

The 90s naming scheme is more forgiving in that regard. The new naming starts to look weird without proper renames.

[Mickeon]

I personally think that going "too" far would do the opposite of what the PR is meant to do, that is, potentially making the code too verbose and actually harder to read.

In fact, and I don't know what to make of this...
I actually prefer to read deg2rad() in the actual source code, but exposed as deg_to_rad() in GDScript (DegToRad() in C#). I don't know what the opinion of most is, but it does look nicer to me in C++.

		// Before.
		p_rotation_offset = Math::deg2rad(rotation_offset->get_value());
		p_rotation_step = Math::deg2rad(rotation_step->get_value());
		
		// After.
		p_rotation_offset = Math::deg_to_rad(rotation_offset->get_value());
		p_rotation_step = Math::deg_to_rad(rotation_step->get_value());

[MewPurPur]

@YuriSizov Shortened terms, even acronyms are OK, but "2" instead of "to" or "too", and "4" instead of "for" - these are more like interwebz slang.

[MewPurPur]

Missed inst2dict and dict2inst.

With these added, I'm 99% sure no methods are missed

[YuriSizov]

Approved for the list present in this PR/linked proposal

[Mickeon]

There's some of these that have been missed in this PR. What about them? Would it still be possible to make a separate PR for them?

[YuriSizov]

You can add inst2dict and dict2inst here, I think. I'm not sure there is anything else that needs changing. Feel free to bring it up, I guess, in the next few days or so.

[akien-mga]

We approved this in a bikeshedding meeting.
I'll check locally to make sure everything is properly converted.

[akien-mga]

C# solution fails building with:

Error: /home/runner/work/godot/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/GD.cs(550,65): error CS1061: 'object' does not contain a definition for 'NativeVar' and no accessible extension method 'NativeVar' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/runner/work/godot/godot/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj]

[Mickeon]

Epic merge fail.

[akien-mga]

There seems to be some code in Mono that might still need porting:

modules/mono/glue/GodotSharp/GodotSharp/Core/DelegateUtils.cs
186:                                    NativeFuncs.godotsharp_var2bytes(var, false.ToGodotBool(), out var varBytes);

modules/mono/glue/GodotSharp/GodotSharp/Core/GD.cs
27:            NativeFuncs.godotsharp_bytes2var(varBytes, allowObjects.ToGodotBool(), out godot_variant ret);
535:            NativeFuncs.godotsharp_str2var(godotStr, out godot_variant ret);
550:            NativeFuncs.godotsharp_var2bytes((godot_variant)var.NativeVar, fullObjects.ToGodotBool(), out var varBytes);
574:            NativeFuncs.godotsharp_var2str((godot_variant)var.NativeVar, out godot_string ret);

modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/NativeFuncs.cs
464:        internal static partial void godotsharp_bytes2var(in godot_packed_byte_array p_bytes,
507:        internal static partial void godotsharp_str2var(in godot_string p_str, out godot_variant r_ret);
509:        internal static partial void godotsharp_var2bytes(in godot_variant p_what, godot_bool p_full_objects,
512:        internal static partial void godotsharp_var2str(in godot_variant p_var, out godot_string r_ret);

modules/mono/glue/runtime_interop.cpp
1236:void godotsharp_var2str(const godot_variant *p_var, godot_string *r_ret) {
1242:void godotsharp_str2var(const godot_string *p_str, godot_variant *r_ret) {
1259:void godotsharp_var2bytes(const godot_variant *p_var, bool p_full_objects, godot_packed_array *r_bytes) {
1271:void godotsharp_bytes2var(const godot_packed_array *p_bytes, bool p_allow_objects, godot_variant *r_ret) {
1482:   (void *)godotsharp_bytes2var,
1502:   (void *)godotsharp_str2var,
1503:   (void *)godotsharp_var2bytes,
1504:   (void *)godotsharp_var2str,

CC @godotengine/dotnet

Everything else seems good.

[Mickeon]

Oooh I did see it, I actually wasn't sure what was the naming scheme used for them (godotsharp_strtovar or godotsharp_str_to_var)?

[raulsntos]

The naming scheme would be godotsharp_str_to_var.

[raulsntos]

The mono module looks good except for a few rebasing mistakes.

[akien-mga]

Thanks!

[aXu-AP]

This is a great, welcome change. As I english isn't my first language, I usually end up reading numbers in my own language (finnish), resulting in strange sounding functions (varkaksistr etc.). I'm sure I'm not the only one who had this problem. Glad it's getting changed :)