Add Cone and Cylinder shapes to FogVolume #61243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
fogvolume-add-cone-cylinder-shape
branch
from
3140d61 to
bed6db5
Compare
Calinou
force-pushed
the
fogvolume-add-cone-cylinder-shape
branch
from
bed6db5 to
f92ceaf
Compare
I'm not sure this is necessary, cone and cylinder are geometric primitives that, by definition, do not have X/Z scaling as they are both defined with a height and radius. In other words, they are not extruded ellipses, they are extruded circles. I am fine merging this without non-uniform scaling (in the X/Z plane). |
This complements the existing Ellipsoid and Box local fog shapes. This can be used to represent a light cone coming from a SpotLight.
Calinou
force-pushed
the
fogvolume-add-cone-cylinder-shape
branch
from
f92ceaf to
e85459d
Compare
clayjohn
approved these changes
May 25, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements the existing Ellipsoid and Box local fog shapes.
This can be used to represent a light cone coming from a SpotLight. See godotengine/godot-proposals#4557.
Preview
fogvolume-cone.mp4
TODO
Implement non-uniform scaling for cone and cylinder shapes based on extents (so that you don't have to scale the FogVolume node instead).