[macOS] Fix driver crash when enabling per-pixel transparency on M1 macs. #55464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 30, 2021
| [window_object setFrame:NSMakeRect(frame.origin.x, frame.origin.y, 1, 1) display:YES]; | ||
| [window_object setFrame:frame display:YES]; | ||
| NSRect frameRect = [window_object frame]; | ||
| [window_object setFrame:NSMakeRect(frameRect.origin.x, frameRect.origin.y, frameRect.size.width + 1, frameRect.size.height) display:NO]; |
There was a problem hiding this comment.
Might be worth adding a comment to clarify the purpose of this call (especially with width + 1, which I guess is to enforce a redraw with a different size?).
There was a problem hiding this comment.
Added comment, yes it's resizing window a bit to trigger GL context update.
bruvzg
force-pushed
the
macos_fix_transp_crash
branch
from
00f7418 to
dd41cf2
Compare
bruvzg
force-pushed
the
macos_fix_transp_crash
branch
from
dd41cf2 to
f72cc71
Compare
akien-mga
approved these changes
Nov 30, 2021
|
Thanks! |
|
Cherry-picked for 3.4.1. |
|
Thanks! Much appreciated! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43951
I have no idea why, but apparently driver do not like resizing window to (1 x 1), which was done to force redraw.