Removes an internal error report if shader fails compile

[Chaosus]

I don't think the user should need to know where in the code internals failed if the shader contains errors:

Note: in the 3.x it does not report it either

[akien-mga]

Thanks!

[akien-mga]

Does it still report shader errors properly when running directly without the editor?

[Chaosus]

Hmm, I think not these errors, just errors made by the user in the shader itself.

[akien-mga]

If we make errors in the Godot's own shader code, we still need to have a way to catch them.

[Chaosus]

Then I guess we should catch them using conditions like if (!editor_hint()) { ERR_FAIL_COND(x) }?

[Chaosus]

Or pass a boolean indicates that this shader is created by the user and not by the engine...

[akien-mga]

Or pass a boolean indicates that this shader is created by the user and not by the engine...

Yeah that might be the better option. The ERR_FAIL was important here, so we need to make sure it's only hidden when we know that the users will be told about the error differently.

[Chaosus]

Yeah that might be the better option.

Ok, I will try to make a pull request for this