Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more error explanations in the BMP image loader #41352

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 18, 2020

This closes #32166 and closes #30629.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:import labels Aug 18, 2020
@Calinou Calinou added this to the 4.0 milestone Aug 18, 2020
@Calinou Calinou force-pushed the bmp-loader-error-explanations branch 2 times, most recently from 44458fa to 8c5ee71 Compare August 18, 2020 14:49
@akien-mga
Copy link
Member

akien-mga commented Aug 18, 2020

modules/bmp/image_loader_bmp.cpp:55:117: error: conversion from 'size_t' (aka 'unsigned long') to 'const Variant' is ambiguous
                                        vformat("1-bpp BMP images must have a width that is a multiple of 8, but the imported BMP is %d pixels wide.", width));
                                                                                                                                                       ^~~~~

You should probably cast to int (or uint64_t).

@Calinou Calinou force-pushed the bmp-loader-error-explanations branch from 8c5ee71 to 40485e2 Compare August 18, 2020 17:41
@akien-mga akien-mga merged commit 9218f0f into godotengine:master Aug 18, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 19, 2020
@Calinou Calinou deleted the bmp-loader-error-explanations branch August 23, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to import bmp files and very poor error details BMP loader fails to import images
2 participants