Fix 38745: Importing FBX of a non-Unicode encoded path causes Assimp throws error #39363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix, can you please update the commit message to be "import" there is a spelling error as you've written "inport". |
RevoluPowered
approved these changes
Jun 7, 2020
|
@RevoluPowered fixed |
akien-mga
added
bug
cherrypick:3.x
|
Thanks! |
|
@akien-mga this was my eleventh commit (source: https://github.com/godotengine/godot/commits?author=MCrafterzz) so will I be added to the contributors list? |
|
Yes, in my next update commit (at the start of July). Which name would like you me to put? |
Marcus (MCrafterzz) |
Anutrix
added a commit
to Anutrix/godot
that referenced
this pull request
Jun 8, 2020
…cene that became unused after the recent commit ec1bf96(godotengine#39363).
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this pull request
Jun 10, 2020
…cene that became unused after the recent commit ec1bf96(godotengine#39363). (cherry picked from commit 365c35f)
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
…cene that became unused after the recent commit ec1bf96(godotengine#39363). (cherry picked from commit 365c35f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38745 by converting the path to utf8