Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle2D showing full texture and not region specified #64671

Closed
chucklepie opened this issue Aug 20, 2022 · 5 comments
Closed

Particle2D showing full texture and not region specified #64671

chucklepie opened this issue Aug 20, 2022 · 5 comments

Comments

@chucklepie
Copy link

Godot version

3.4.4

System information

PopOS

Issue description

I have a sprite map/atlas and for a Particle2D texture I have set a region as shown below.
image

However, when the particle is emitted, it shows the full texture
image

I did search for an existing one, apologies if already a bug.

Steps to reproduce

Exactly as above really

Minimal reproduction project

No response

@chucklepie
Copy link
Author

chucklepie commented Aug 20, 2022

I've just checked the documentation and it says this:
Note: Unlike CPUParticles2D, Particles2D currently ignore the texture region defined in AtlasTextures.

So is this why? If so, two questions:

  1. Why is the setting still in the properties and why no hint given when it's known it is a particle2D and not a cpu particle, making everyone think texture regions are supported?
  2. Is this a limitation of OGL or just a bug/feature not implemented in Godot?

@KoBeWi
Copy link
Member

KoBeWi commented Aug 20, 2022

Duplicate of #13923

Is this a limitation of OGL or just a bug/feature not implemented in Godot?

AtlasTexture is just a wrapper for the texture on GPU. Most nodes draw textures using the regular texture draw function, which handles AtlasTexture in a specific way, but GPU particles work differently. You e.g. need a special material to use animations, so not sure if handling atlases in particles is possible. It would need to be done explicitly in the shader.

@KoBeWi KoBeWi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2022
@chucklepie
Copy link
Author

@KoBeWi
Ok (sorry, I replied by email, maybe it didn't arrive). If this doesn't work as expected how come the IDE lets you happily do it and the hints provide no indication either. Should this facility be disabled or at a least a tooltip hint provided (there is none) that at least tells people atlas textures don't work for particle2D?

@KoBeWi
Copy link
Member

KoBeWi commented Aug 21, 2022

Should this facility be disabled or at a least a tooltip hint provided (there is none) that at least tells people atlas textures don't work for particle2D?

Makes sense.

@chucklepie
Copy link
Author

chucklepie commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants