Map Vector2.Axis and Vector2i.Axis to Vector2Axis
#1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsep
force-pushed
the
feature/vector2-axis-mapped
branch
from
e1348f6 to
0ecea78
Compare
|
Thank you! Out of curiosity, in which APIs did you encounter this? |
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1012 |
I was working of extending PhysicsServer2D of Godot to better support godot-rapier. Having Vector2::Axis arguments there would break gdext build. |
Missing mapping can cause problems when building bindings for custom Godot or GDExtensions using those enums.
Bromeon
force-pushed
the
feature/vector2-axis-mapped
branch
from
0ecea78 to
ae789d9
Compare
Bromeon
added
feature
|
Added a comment so it's not accidentally removed due to "unused" in the future. |
Bromeon
changed the title
Vector2.Axis and Vector2i.Axis to Vector2Axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing mapping can cause problems when building bindings for custom Godot or gdextensions using those enums.
Similar to #797.