Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer, would like to setup a devcontainer #111

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jeffbean
Copy link

for integration testing to be more deterministic.

golang/go#12868 (comment)

One code change that i think is overall safe.

 for integration testing to be more deterministic.

golang/go#12868 (comment)

One code change that i think is overall safe.
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.59 ⚠️

Comparison is base (abd6db4) 76.78% compared to head (3996724) 76.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   76.78%   76.19%   -0.59%     
==========================================
  Files           7        7              
  Lines        1193     1193              
==========================================
- Hits          916      909       -7     
- Misses        189      193       +4     
- Partials       88       91       +3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeffbean
Copy link
Author

@yarikk or @pmazzini can I get owner membership for the organization?

@pmazzini
Copy link

Done

@jeffbean jeffbean merged commit 9ea55d9 into go-zookeeper:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants