Skip to content

Commit

Permalink
devcontainer, would like to setup a devcontainer
Browse files Browse the repository at this point in the history
 for integration testing to be more deterministic.

golang/go#12868 (comment)

One code change that i think is overall safe.
  • Loading branch information
jeffbean committed Jul 28, 2023
1 parent abd6db4 commit 9ea55d9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/go
{
"name": "Go",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/go:0-1-bullseye",
"features": {
"ghcr.io/devcontainers/features/java:1": {
}
}
}
2 changes: 1 addition & 1 deletion server_java_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (srv *server) Start() error {
srv.cmd = exec.CommandContext(ctx, srv.cmdString, srv.cmdArgs...)
srv.cmd.Stdout = srv.stdout
srv.cmd.Stderr = srv.stderr
srv.cmd.Env = srv.cmdEnv
srv.cmd.Env = append(os.Environ(), srv.cmdEnv...)

return srv.cmd.Start()
}
Expand Down

0 comments on commit 9ea55d9

Please sign in to comment.