Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Samba Move Object #286

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Fixed Samba Move Object #286

merged 6 commits into from
Oct 14, 2020

Conversation

duygupotur
Copy link
Contributor

This pr fixes #194

@mertcelen
Copy link

We need this pr to merged ASAP.

Copy link
Contributor

@stefanmcshane stefanmcshane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes to be made before approval
Tag me and I will help get this approved for you asap

moddn.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
v3/go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@mertcelen
Copy link

@stefanmcshane changes applied :)

@stefanmcshane
Copy link
Contributor

@mertcelen Still a few failing tests - all PRs are blocked until the tests pass

@mertcelen
Copy link

@stefanmcshane you are absolutely right to ask for tests but if you check closer, there seems to be a bug with older go version tests itself. If I'm not wrong, it has nothing to do with our change. I'll gladly help if that's the case but since you flagged them as legacy and google obviously dropped support for it https://golang.org/doc/devel/release.html#policy we may as well just delete those.

Your call.

@stefanmcshane
Copy link
Contributor

stefanmcshane commented Oct 13, 2020

@mertcelen Whilst I wouldn't use Go's release history as an argument as the scopes are very different, I would agree that we should review the supported legacy versions going forward. This would need to be done as a separate PR, before merging this change.

@johnweldon Opinions on this? We would be potentially breaking backwards compatibility for any Go versions <= 1.6 (released 2016, support dropped 2017).
However, I would suggest dropping support for 1.5 and 1.6 in a new PR, tagging as a hotfix release (v3.2.4), then merging this PR.
EDIT: Issue raised: #287, with PR in #288

Aside: This would also provide a strong segue for tidying go modules up further, by dropping support for non-module installation, and making the new default branch "v3". If you agree to the above, I'll open a new issue for discussion on go module related updates.

@stefanmcshane stefanmcshane merged commit e07632f into go-ldap:master Oct 14, 2020
@stefanmcshane
Copy link
Contributor

@mertcelen @ZDuygu This has been tagged v3.2.4 and released. Thank you for your contributions and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAMBA AD: LDAP Result Code 53 "Unwilling To Perform": 00002035: Unwilling to perform. Old RDN must be deleted
3 participants