Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for legacy Go versions <1.7 #287

Closed
stefanmcshane opened this issue Oct 13, 2020 · 1 comment · Fixed by #288
Closed

Drop support for legacy Go versions <1.7 #287

stefanmcshane opened this issue Oct 13, 2020 · 1 comment · Fixed by #288

Comments

@stefanmcshane
Copy link
Contributor

Drop legacy support for Go versions <1.7 as builds are breaking due to introductions in the test package since 1.6
#286 as an example
https://golang.org/pkg/testing/#T.Run

Go 1.6 was last supported in 2017, when Go 1.8 was released.
https://golang.org/doc/devel/release.html#policy
https://blog.golang.org/go1.8
This was referenced Oct 13, 2020
Merged
Merged
@johnweldon
Copy link
Member

I'm surprised we missed this previously when the t.Run calls were added.

Nevertheless, I support updating the minimum supported version to 1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dropped test coverage support from legacy go versions: go1.5 go1.6
2 participants
@johnweldon @stefanmcshane