Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send issue closure email with correct user - fixes #7124 #7164

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 9, 2019

Lightly tested.

For anyone testing: Because of #5977, the closure must be done with a non-empty comment for it to send a mail.

@codecov-io
Copy link

Codecov Report

Merging #7164 into master will decrease coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7164      +/-   ##
==========================================
- Coverage   41.76%   41.76%   -0.01%     
==========================================
  Files         448      448              
  Lines       61061    61061              
==========================================
- Hits        25503    25501       -2     
- Misses      32245    32247       +2     
  Partials     3313     3313
Impacted Files Coverage Δ
modules/notification/mail/mail.go 22.64% <0%> (ø) ⬆️
models/issue_mail.go 54.76% <75%> (ø) ⬆️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de0b0a...6cba441. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 9, 2019
@silverwind
Copy link
Member Author

silverwind commented Jun 9, 2019

Further testing reveals more existing bugs related to close/reopen mails (comment/open actions do work), I have a hard time triggering them consistently at all during testing. I will try to fix these as well and send another PR later with both fixes as this PR alone is kind of worthless on its own.

@silverwind silverwind closed this Jun 9, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants