Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue closure email has wrong From header #7124

Closed
silverwind opened this issue Jun 4, 2019 · 0 comments · Fixed by #7165
Closed

Issue closure email has wrong From header #7124

silverwind opened this issue Jun 4, 2019 · 0 comments · Fixed by #7165
Labels
type/bug

Comments

@silverwind
Copy link
Member

To reproduce:

  1. Open issue as user1
  2. Close issue as user2
  3. The resulting mail with body Closed #id is using From: user1 header, should be From: user2.
@lunny lunny added the type/bug label Jun 5, 2019
silverwind added a commit to silverwind/gitea that referenced this issue Jun 9, 2019
@silverwind
Send issue closure email with correct user - fixes go-gitea#7124
6cba441
@silverwind silverwind mentioned this issue Jun 9, 2019
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Jun 9, 2019
@silverwind
Various fixes for issue mail notifications
59d4674 
- Send individual mails for actions and comments
- Send mail for new issues/prs without a comment
- Use correct sender for reopen/close actions
- Hopefully fixed all bugs related to missing mails

Fixes: go-gitea#7124
Fixes: go-gitea#5977
zeripath pushed a commit that referenced this issue Jun 11, 2019
@silverwind @zeripath
Various fixes for issue mail notifications (#7165)
499a8a1 
- Send individual mails for actions and comments
- Send mail for new issues/prs without a comment
- Use correct sender for reopen/close actions
- Hopefully fixed all bugs related to missing mails

Fixes: #7124
Fixes: #5977
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this issue Jul 18, 2019
@silverwind @jeffliu27
Various fixes for issue mail notifications (go-gitea#7165)
e19f5dd 
- Send individual mails for actions and comments
- Send mail for new issues/prs without a comment
- Use correct sender for reopen/close actions
- Hopefully fixed all bugs related to missing mails

Fixes: go-gitea#7124
Fixes: go-gitea#5977
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various fixes for issue mail notifications silverwind/gitea
2 participants
@lunny @silverwind