-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize branch protection rule loading #32280
base: main
Are you sure you want to change the base?
Optimize branch protection rule loading #32280
Conversation
the followup work will make glob rules order by user define priority ... so you dont have to delete and recreate rules just to have the correct order ... |
I suggest to not handle the non-glob rules differently. I can imagine a order of rules where a non-glob rule might should kick in between two glob rules. Also from a user perspective it is probably confusing why the one rule is added "in the middle" while the other is added to the end. If you handle both type the same the user interface becomes easier understandable. |
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
I would like to priority rather than this one. |
currently we only sort branch protection rules by creation time and type.
this change the order for non glob names as it make no difference to be alphabetical.
Sponsored by Kithara Software GmbH