Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent from submitting issue/comment on uploading #32263

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Prevent from submitting issue/comment on uploading #32263

merged 9 commits into from
Oct 23, 2024

Conversation

sangcheol12
Copy link
Contributor

@sangcheol12 sangcheol12 commented Oct 15, 2024 •
edited
Loading

fix #32262

fix for new comment

스크린샷 2024-10-15 오후 1 21 08

fix for edit comment

스크린샷 2024-10-15 오후 6 03 22

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 15, 2024
@yp05327
Copy link
Contributor

yp05327 commented Oct 15, 2024 •
edited
Loading

I found that the comment button here (in files changes tab) will not be checked (it will always be enabled), as what it does in conversation tab.
image
Do you have interest fixing it together? 😄

Of cause, if you want, you can do it in another PR.

Edited:
Edit comment also has this issue. But IIRC, editing comment can be empty.
image

@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Oct 15, 2024
@yp05327 yp05327 added this to the 1.23.0 milestone Oct 15, 2024
@sangcheol12
Copy link
Contributor Author

@yp05327
I'll address the issue with the edit comment in this PR as well. As for the issue in the files changes tab, I'll follow up with a separate PR to fix that. Thanks for pointing it out!

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 20, 2024
@wxiaoguang wxiaoguang removed type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 21, 2024
@sangcheol12 sangcheol12 force-pushed the fix/prevent-comment-on-uploading branch from 0a116c6 to f3c7c26 Compare October 22, 2024 06:59
@sangcheol12
Copy link
Contributor Author

I rewrote my code. Please review again.

@wxiaoguang wxiaoguang self-assigned this Oct 22, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2024
@wxiaoguang
Copy link
Contributor

In e94463c, I think most problems are resolved.

It uses EventUploadStateChanged to handle the upload-related events.

(ps: there are many TypeScript fixing changes, to make the code conform to the strict types ....)

Hopefully it works as expected for you.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 22, 2024
@wxiaoguang wxiaoguang changed the title prevent comment on uploading Prevent from submitting issue/comment on uploading Oct 22, 2024
@wxiaoguang wxiaoguang removed their assignment Oct 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 22, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 22, 2024
@wxiaoguang wxiaoguang merged commit 620f196 into go-gitea:main Oct 23, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 23, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2d1d485 
* giteaofficial/main:
  Fix broken image when editing comment with non-image attachments (go-gitea#32319)
  Fix disable 2fa bug (go-gitea#32320)
  Upgrade rollup to 4.24.0 (go-gitea#32312)
  Upgrade vue to 3.5.12 (go-gitea#32311)
  Make admins adhere to branch protection rules (go-gitea#32248)
  Prevent from submitting issue/comment on uploading (go-gitea#32263)
  Add warn log when deleting inactive users (go-gitea#32318)
  Add `DISABLE_ORGANIZATIONS_PAGE` and `DISABLE_CODE_PAGE` settings for explore pages and fix an issue related to user search (go-gitea#32288)
  chore: fix some function names in comment (go-gitea#32300)
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 30, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into types-4
5600f34 
* origin/main: (21 commits)
  Fix toAbsoluteLocaleDate and add more tests (go-gitea#32387)
  Respect UI.ExploreDefaultSort setting again (go-gitea#32357)
  Fix absolute-date (go-gitea#32375)
  Fix undefined errors on Activity page (go-gitea#32378)
  Add new [lfs_client].BATCH_SIZE and [server].LFS_MAX_BATCH_SIZE config settings. (go-gitea#32307)
  remove unused call to $.HeadRepo in view_title template (go-gitea#32317)
  Fix clean tmp dir (go-gitea#32360)
  Optimize branch protection rule loading (go-gitea#32280)
  Suggestions for issues (go-gitea#32327)
  Migrate vue components to setup (go-gitea#32329)
  Fix db engine (go-gitea#32351)
  Refactor the DB migration system slightly (go-gitea#32344)
  Fix broken image when editing comment with non-image attachments (go-gitea#32319)
  Fix disable 2fa bug (go-gitea#32320)
  Upgrade rollup to 4.24.0 (go-gitea#32312)
  Upgrade vue to 3.5.12 (go-gitea#32311)
  Make admins adhere to branch protection rules (go-gitea#32248)
  Prevent from submitting issue/comment on uploading (go-gitea#32263)
  Add warn log when deleting inactive users (go-gitea#32318)
  Add `DISABLE_ORGANIZATIONS_PAGE` and `DISABLE_CODE_PAGE` settings for explore pages and fix an issue related to user search (go-gitea#32288)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Comment button should be disabled on uploading images..
5 participants
@sangcheol12 @yp05327 @wxiaoguang @lunny @GiteaBot