Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use querySelector over alternative DOM methods #31280

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Use querySelector over alternative DOM methods #31280

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be3794c
Use `querySelector` over alternative DOM methods
silverwind Jun 7, 2024
16516c5
also handle document.getElementsByName
silverwind Jun 7, 2024
4683c44
Update web_src/js/markup/anchors.js
silverwind Jun 7, 2024
c9e1724
fix syntax
silverwind Jun 7, 2024
6c688d0
Merge branch 'main' into querySelector
GiteaBot Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web_src/js/markup/anchors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ function scrollToAnchor(encodedId) {

// check for matching user-generated `a[name]`
if (!el) {
const nameAnchors = document.getElementsByName(prefixedId);
if (nameAnchors.length) {
el = nameAnchors[0];
const nameAnchor = document.querySelector(`[name="${CSS.escape(prefixedId)}"]`);
if (nameAnchor) {
el = nameAnchor;
silverwind marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down