Use querySelector over alternative DOM methods
#31280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
added
the
type/refactoring
|
16516c5 also fixes the one use of |
wxiaoguang
reviewed
Jun 7, 2024
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
|
anchors tested again, still work. |
wxiaoguang
approved these changes
Jun 7, 2024
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Jun 10, 2024
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 11, 2024
* giteaofficial/main: Fix line number width in code preview (go-gitea#31307) Delete legacy cookie before setting new cookie (go-gitea#31306) [skip ci] Updated translations via Crowdin Use `querySelector` over alternative DOM methods (go-gitea#31280) Remove jQuery `.text()` (go-gitea#30506) [skip ci] Updated translations via Crowdin Remove sub-path from container registry realm (go-gitea#31293) Fix some URLs whose sub-path is missing (go-gitea#31289)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #30115 (comment), prefer
querySelectorby enablingunicorn/prefer-query-selectorand autofixing all except 10 issues.According to this, querySelector may be faster as well, so it's a win-win.