Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and restyle reaction selector and enable no-sizzle eslint rule (#30453) #30473

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Rewrite and restyle reaction selector and enable no-sizzle eslint rule (#30453) #30473

merged 2 commits into from
Apr 14, 2024

Commits on Apr 14, 2024

  1. Rewrite and restyle reaction selector and enable no-sizzle eslint rule ( 

    go-gitea#30453)

Enable `no-sizzle` lint rule, there was only one use in `initCompReactionSelector` and:

- Remove all jQuery except the necessary fomantic dropdown init
- Remove the recursion, instead bind event listeners to common parent container nodes

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
    @silverwind @wxiaoguang @GiteaBot
    3 people committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    2031ae9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v1.22' into backport-30453-v1.22

    @GiteaBot
    GiteaBot authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    943668e View commit details
    Browse the repository at this point in the history