Rewrite and restyle reaction selector and enable no-sizzle eslint rule

[silverwind]

Enable no-sizzle lint rule, there was only one use in initCompReactionSelector which I have rewritten as follows:

• Remove all jQuery except the necessary fomantic dropdown init
• Remove the recursion, instead bind event listeners to common parent container nodes

Did various tests, works with our without attachments, in diff view and in diff comments inside comment list.

Additionally the style of reactions now matches between code comments and issue comments:

[silverwind]

Found one pre-existing bug in diff comments where all reactions go missing after clicking a existing reaction in the emoji button.

[wxiaoguang]

Major changes:

• clean up unnecessary CSS styles
• make the selectors have clear names (now we can search select-reaction and comment-reaction-button globally to see how they work)
• simplify the JS code, some logic are dead code from legacy, and I think the code reads better now

[silverwind]

Hmm, I get 500 now:

Render failed, failed to render template: repo/issue/view, error: template error: builtin(static):repo/issue/view_content/reactions:3:33 : executing "repo/issue/view_content/reactions" at <ctx>: invalid value; expected int64
----------------------------------------------------------------------
	{{$hasReacted := $value.HasUser ctx.RootData.SignedUserID}}

Hmm I'm getting this now after a make clean-all when viewing certain PRs.

[silverwind]

It seems ctx.RootData.SignedUserID is nil.

[wxiaoguang]

Hmm I'm getting this now after a make clean-all when viewing certain PRs.

Is it reproducible?

[silverwind]

It's strange, it only happens on one specific PR in my dev instance, others work.

[wxiaoguang]

Could you add {{DumpVar ctx.RootData}} to see its content?

[silverwind]

It seems NewTemplateContextForWeb is not being called.

[silverwind]

{{DumpVar ctx.RootData}}

dumpVar: <nil> null

[wxiaoguang]

It seems NewTemplateContextForWeb is not being called.

That seems impossible ... if NewTemplateContextForWeb isn't called, then NewWebContext isn't called, then the whole ctx system is impossible to work.

---

Then what's the {{DumpVar ctx}} ?

[silverwind]

{{DumpVar ctx}}

It's there, and massive.

dumpVar: context.TemplateContext
{
  "AvatarUtils": {},
  "Locale": {
    "Lang": "en-US",
    "LangName": "English",
    "Locale": {}
  },
  "_ctx": {
    "Base": {
      "Data": {
        "AllLangs": [
          {

[silverwind]

So something else must be rendering the template before NewWebContext is ran.

[wxiaoguang]

{{DumpVar ctx}}

It's there, and massive.

Do you see RootData in the output? If no, it means that you are running a incorrect backend.

[silverwind]

Errors is happening here:

2024/04/14 16:36:47 .../context_response.go:87:HTML() [E] Render failed: failed to render template: repo/issue/view, error: template error: builtin(static):repo/issue/view_content/reactions:4:33 : executing "repo/issue/view_content/reactions" at <ctx>: invalid value; expected int64
----------------------------------------------------------------------
	{{$hasReacted := $value.HasUser ctx.RootData.SignedUserID}}
	                                ^
----------------------------------------------------------------------

[wxiaoguang]

{{DumpVar ctx}}

It's there, and massive.

Do you see RootData in the output? If no, it means that you are running a incorrect backend.

Do you see RootData (the map key) in the {{DumpVar ctx}} output? If no, it means that you are running a incorrect backend.

[silverwind]

Ok I found it, there was a zombie process, presumably from unclean make watch termination, killed it, now it's ok. I wonder if I can make make watch more reliably kill the processes.

[wxiaoguang]

That's why I said many times I don't use make watch ........... so my code is generally stable enough 😁

[silverwind]

That's why I said many times I don't use make watch ........... so my code is generally stable enough 😁

I think the problem is air sometimes not killing off the child, I think #30477 should help, at least on subsequent air runs.