Refactor "editorconfig" #26391
Merged
Refactor "editorconfig" #26391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
approved these changes
Aug 8, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 8, 2023
GiteaBot
added
lgtm/done
wxiaoguang
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
Would like to mention related issue #24991, just in case you have any idea where we are missing this context variable 😆. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 9, 2023
* upstream/main: [skip ci] Updated translations via Crowdin fix artifact merging chunks path with correct slash on Windows (go-gitea#26400) Use flex classes in package settings (go-gitea#26314) Improve multiple strings in en-US locale (go-gitea#26213) Refactor "editorconfig" (go-gitea#26391) fix generated source URL on rendered files (go-gitea#26364) Remove unnecessary template helper DisableGravatar (go-gitea#26386)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 kinds of ".Editorconfig" in code, one is
JSON stringfor the web edtior, another is*editorconfig.Editorconfigfor the file rendering (used byTabSizeClass)This PR distinguish them with different names.
And by the way, change the default tab size from 8 to 4, I think few people would like to use 8-size tabs nowadays.