Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flex classes in package settings #26314

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Aug 3, 2023

Regression of #25790
Fixes #26310

@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 3, 2023
@KN4CK3R KN4CK3R added this to the 1.21.0 milestone Aug 3, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 3, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 4, 2023
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Aug 6, 2023

Found another regression.
grafik

@silverwind
Copy link
Member

cc: @denyskon

Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I must have overlooked this.......

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 8, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 8, 2023
@silverwind silverwind merged commit e6f8e93 into go-gitea:main Aug 8, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 8, 2023
@silverwind
Copy link
Member

#26314 (comment) is still unresolved as far as I can tell, in case you want to have a look @denyskon.

@denyskon
Copy link
Member

denyskon commented Aug 8, 2023

#26314 (comment) is still unresolved as far as I can tell, in case you want to have a look @denyskon.

Isn't it resolved by dbaa94b ?

@silverwind
Copy link
Member

Ah yes, indeed. I was thrown off by the fact the the comment came after the commit :D

zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 9, 2023
* upstream/main:
  [skip ci] Updated translations via Crowdin
  fix artifact merging chunks path with correct slash on Windows (go-gitea#26400)
  Use flex classes in package settings (go-gitea#26314)
  Improve multiple strings in en-US locale (go-gitea#26213)
  Refactor "editorconfig" (go-gitea#26391)
  fix generated source URL on rendered files (go-gitea#26364)
  Remove unnecessary template helper DisableGravatar (go-gitea#26386)
@KN4CK3R KN4CK3R deleted the fix-26130 branch August 14, 2023 19:16
@KN4CK3R KN4CK3R changed the title Use flex classes in package settings Use flex classes in package settings (test) Sep 3, 2023
@KN4CK3R KN4CK3R changed the title Use flex classes in package settings (test) Use flex classes in package settings Sep 3, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css bug in /$org/-/packages/container/$foo/latest/settings
5 participants