Fix admin config page error, use tests to cover the admin config and 500 error page #24965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
added
the
skip-changelog
silverwind
reviewed
May 28, 2023
wxiaoguang
force-pushed
the
fix-admin-config
branch
from
3645649
to
79118aa
Compare
silverwind
approved these changes
May 28, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 29, 2023
GiteaBot
added
lgtm/done
lunny
reviewed
May 29, 2023
| defer tests.PrepareTestEnv(t)() | ||
|
|
||
| session := loginUser(t, "user1") | ||
| req := NewRequest(t, "GET", "/admin/config") |
There was a problem hiding this comment.
Maybe we can have more links from /admin to test?
lunny
added
the
reviewed/wait-merge
delvh
approved these changes
May 29, 2023
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 30, 2023
* upstream/main: Remove unnecessary content on docs (go-gitea#24976) Upgrade snap to node 20 (go-gitea#24990) Display file mode for new file and file mode changes (go-gitea#24966) Enable `vue/html-closing-bracket-spacing` eslint rule (go-gitea#24987) Fix repo level project - edit column (go-gitea#24982) Add v3.18 to TestPackageAlpine (go-gitea#24972) Fix admin config page error, use tests to cover the admin config and 500 error page (go-gitea#24965) Improve dropdown menus, remove inline styles (go-gitea#24954) Unify doc links to use paths relative to doc folder (go-gitea#24979) Rework button coloring, add focus and active colors (go-gitea#24507) Add PDF rendering via PDFObject (go-gitea#24086) Hide 'Mirror Settings' when unneeded, improve hints (go-gitea#24433) Consolidate the two review boxes into one (go-gitea#24738) API endpoint for changing/creating/deleting multiple files (go-gitea#24887) Repo list improvements, fix bold helper classes (go-gitea#24935) Add step start time to `ViewStepLog` (go-gitea#24980) Update from-binary.en-us.md (go-gitea#24975)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin config page has been broken for many many times, a little refactoring would make this page panic.
So, add a test for it, and add another test to cover the 500 error page.