Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dropdown menus, remove inline styles #24954

Merged
merged 16 commits into from
May 29, 2023
Merged

Improve dropdown menus, remove inline styles #24954

merged 16 commits into from
May 29, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 27, 2023 •
edited
Loading

Before:

Screenshot 2023-05-27 at 10 46 43

After:

Screenshot 2023-05-28 at 19 29 03

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2023
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2023
@wxiaoguang
Copy link
Contributor

How about just removing these "headers" in the dropdown menu?

I don't find these headers provide useful information. Without them, the UI looks better to me:

image

image

@silverwind
Copy link
Member Author

Yeah I had the same feeling, they are pretty pointless in general, also in the reaction dropdown.

@silverwind silverwind mentioned this pull request May 27, 2023
Merged
@silverwind silverwind marked this pull request as draft May 27, 2023 11:17
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2023
@silverwind silverwind marked this pull request as ready for review May 27, 2023 22:13
@silverwind
Copy link
Member Author

silverwind commented May 27, 2023 •
edited
Loading

Ok I have removed all titles from issue sidebar dropdowns now. There are a few remaining cases where title is still used for "No Items", I guess I'll leave those as-is.

@silverwind silverwind marked this pull request as draft May 28, 2023 17:26
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2023
@silverwind
Copy link
Member Author

Now using disabled item:

Screenshot 2023-05-28 at 19 29 03

@silverwind silverwind marked this pull request as ready for review May 28, 2023 17:30
@silverwind silverwind changed the title Remove a few inline styles Improve dropdown menus, remove inline styles May 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 29, 2023
@silverwind silverwind enabled auto-merge (squash) May 29, 2023 10:34
@GiteaBot
Copy link
Contributor

@silverwind please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 29, 2023
@silverwind
Merge remote-tracking branch 'origin/main' into rmstyle
f89e8a2 
* origin/main:
  Hide 'Mirror Settings' when unneeded, improve hints (go-gitea#24433)
  Consolidate the two review boxes into one (go-gitea#24738)
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 29, 2023
@silverwind silverwind merged commit 73b57c2 into go-gitea:main May 29, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 29, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 29, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 30, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
d37b097 
* upstream/main:
  Remove unnecessary content on docs (go-gitea#24976)
  Upgrade snap to node 20 (go-gitea#24990)
  Display file mode for new file and file mode changes (go-gitea#24966)
  Enable `vue/html-closing-bracket-spacing` eslint rule (go-gitea#24987)
  Fix repo level project - edit column  (go-gitea#24982)
  Add v3.18 to TestPackageAlpine (go-gitea#24972)
  Fix admin config page error, use tests to cover the admin config and 500 error page (go-gitea#24965)
  Improve dropdown menus, remove inline styles (go-gitea#24954)
  Unify doc links to use paths relative to doc folder (go-gitea#24979)
  Rework button coloring, add focus and active colors (go-gitea#24507)
  Add PDF rendering via PDFObject (go-gitea#24086)
  Hide 'Mirror Settings' when unneeded, improve hints (go-gitea#24433)
  Consolidate the two review boxes into one (go-gitea#24738)
  API endpoint for changing/creating/deleting multiple files (go-gitea#24887)
  Repo list improvements, fix bold helper classes (go-gitea#24935)
  Add step start time to `ViewStepLog` (go-gitea#24980)
  Update from-binary.en-us.md (go-gitea#24975)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @wxiaoguang @GiteaBot @delvh @lunny