-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering of external links #2292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
force-pushed
the
fix/render_link
branch
2 times, most recently
from
August 11, 2017 04:51
d05c968
to
0a8d2d7
Compare
CI failed |
tboerger
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 11, 2017
ethantkoenig
force-pushed
the
fix/render_link
branch
from
August 11, 2017 05:26
0a8d2d7
to
299270a
Compare
LGTM |
tboerger
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 13, 2017
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 13, 2017
This was referenced Aug 13, 2017
Closed
@ethantkoenig could you send a back port PR to release/v1.1 ? |
ethantkoenig
added a commit
to ethantkoenig/gitea
that referenced
this pull request
Aug 17, 2017
lunny
pushed a commit
that referenced
this pull request
Aug 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2282 (both space-consuming bug and rendering-external-link-as-internal-issue bug).
Some minor points:
{Setting.AppURL}/:owner/:repo/(issues|pulls)/:index
<i class="icon comment"></i>
to the displayed text for links to comments. However, due to client-side JS, the icon was never rendered. Ideally, I think we should append(comment)
like Github does. However, adding this would require some extra refactoring (to support multiple languages), so I put it in a TODO