Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debatable rendering of external link (and missing space) #2282

Closed
strk opened this issue Aug 8, 2017 · 1 comment · Fixed by #2292
Closed

Debatable rendering of external link (and missing space) #2282

strk opened this issue Aug 8, 2017 · 1 comment · Fixed by #2292
Assignees
Labels
Milestone

Comments

@strk
Copy link
Member

strk commented Aug 8, 2017

A link to an issue on a foreign code hosting is rendered as just #6 and the space before it is removed. See https://try.gitea.io/strk/postgis/pulls/1

The source code of that PR description is:

Mirror of https://git.osgeo.org/gogs/postgis/postgis/pulls/6

It is rendered as:

Mirror of#6

Reported gitea version at the time of writing this report: 27798c3

@strk strk changed the title Debatable rendering of extenral link (and missing space) Debatable rendering of external link (and missing space) Aug 8, 2017
@lunny lunny added the type/bug label Aug 9, 2017
@lunny lunny added this to the 1.2.0 milestone Aug 9, 2017
@ethantkoenig
Copy link
Member

It seems there are tests in markdown_test.go that explicitly check for this.

I agree that we should only render issue links for internal links, instead of assuming that any URL ending in a number points to some sort of issue, and am happy to make the fix. I just want to make sure there is consensus before actually making changes.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants