Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume all 40 char strings are SHA1s (#14624) #14648

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Do not assume all 40 char strings are SHA1s (#14624) #14648

merged 1 commit into from
Feb 13, 2021

Commits on Feb 11, 2021

  1. Do not assume all 40 char strings are SHA1s (go-gitea#14624) 

    Backport go-gitea#14624

GetCommit() assumes that all 40 char strings are SHA1s. This leads to an
error if you try to do a PR on a branch which is 40 characters long.

This PR attempts the SHA first - and if it fails will switch to using rev-parse.

Fix go-gitea#14470

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    ae8233e View commit details
    Browse the repository at this point in the history