Do not assume all 40 char strings are SHA1s #14624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetCommit() assumes that all 40 char strings are SHA1s. This leads to an error if you try to do a PR on a branch which is 40 characters long. This PR attempts the SHA first - and if it fails will switch to using rev-parse. Fix go-gitea#14470 Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Feb 10, 2021
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Feb 10, 2021
GiteaBot
added
lgtm/done
|
Make lgtm work |
zeripath
deleted the
fix-14470-dont-assume-all-40-char-strings-are-shas
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 11, 2021
Backport go-gitea#14624 GetCommit() assumes that all 40 char strings are SHA1s. This leads to an error if you try to do a PR on a branch which is 40 characters long. This PR attempts the SHA first - and if it fails will switch to using rev-parse. Fix go-gitea#14470 Signed-off-by: Andrew Thornton <art27@cantab.net>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetCommit() assumes that all 40 char strings are SHA1s. This leads to an
error if you try to do a PR on a branch which is 40 characters long.
This PR attempts the SHA first - and if it fails will switch to using rev-parse.
Fix #14470
Fix #14420
Signed-off-by: Andrew Thornton art27@cantab.net