Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more Settings -> Deploy Keys on an unitialized repository #30620

Closed
hweidner opened this issue Apr 20, 2024 · 3 comments
Closed

No more Settings -> Deploy Keys on an unitialized repository #30620

hweidner opened this issue Apr 20, 2024 · 3 comments
Labels
Milestone

Comments

@hweidner
Copy link

Description

When creating a new uninitialized repository, the Settings menu does not offer the Deploy Keys option any more. Only Repository, Collaborators and Webhooks are shown. Older repositories also offer Branches, Tags, Deploy Keys, and LFS.

The behaviour has changed within the last versions. When I created a new uninitialized repository some weeks ago, it was possible to add a Deploy Key via the Settings menu.

I cannot tell if the bug is reproducible on try.gitea.io because it times out when I try to register there.

Gitea Version

1.21.11

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

The Settings menu on a newly created repository.

grafik

Git Version

No response

Operating System

Debian 12 with Docker 20.10.24+dfsg1

How are you running Gitea?

I am using the official Docker image gitea/gitea:1 with automatic updates via watchtower.

The commandline is

# docker run -d --restart=always --name gitea -p 22:22 -p 3000:3000 -v /srv/gitea/data:/data gitea/itea:1

Database

MySQL/MariaDB

@lunny
Copy link
Member

lunny commented Apr 21, 2024

I think this change is by design. The logic is if there is no branches, so we don't need UI to do that. From my current situation, maybe protected branches/tags are necessary before there is any code.

@hweidner
Copy link
Author

The logic is if there is no branches, so we don't need UI to do that.

I understand your argument regarding Branches and Tags. But Deploy Keys should be still configurable even to an empty (uninitialized) repository. To create an uninitialized reposory in Gitea, enter an SSH key and then push an existing repository over SSH is a perfectly valid workflow.

@lunny lunny added this to the 1.21.12 milestone Apr 22, 2024
lunny added a commit that referenced this issue Apr 23, 2024
Fix #30620 
Manullay Backport #29130

Shows more settings for empty repositories (Fixes #29060)

Co-authored-by: Tim-Nicas Oelschläger <72873130+zokkis@users.noreply.github.com>
@lunny
Copy link
Member

lunny commented Apr 23, 2024

Closed by #30635

@lunny lunny closed this as completed Apr 23, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants