Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Technitium #2332

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Add DNS provider for Technitium #2332

merged 4 commits into from
Nov 10, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 9, 2024

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
    make build
    rm -rf .lego
    
    TECHNITIUM_SERVER_BASE_URL="http://localhost:5380" \
    TECHNITIUM_API_TOKEN="xxxxxxxxxxxxxxxxxxxxx" \
    ./dist/lego --email you@example.com --dns technitium -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @abdeldjalil-fellah, can you run the command (with your domain, email, credentials, etc.)?

Closes #2331

How to test this PR?
  1. You need Go
  2. Checkout the PR:
    git clone https://github.com/ldez/lego.git
    cd lego
    git checkout feat/technitium
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build ./cmd/lego -o dist/lego
  4. Run the following command with your information (email, domain, credentials, etc.):
    TECHNITIUM_SERVER_BASE_URL="http://localhost:5380" \
    TECHNITIUM_API_TOKEN="xxxxxxxxxxxxxxxxxxxxx" \
    ./dist/lego --email you@example.com --dns technitium -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment:
    rm -rf .lego

Related to #2331 (reply in thread)

@ldez ldez added enhancement area/dnsprovider state/need-user-tests Need users to test functionality labels Nov 9, 2024
@ldez ldez changed the title Add DNS provider for Add DNS provider for Technitium Nov 9, 2024
@ldez
Copy link
Member Author

ldez commented Nov 9, 2024

Maybe @ShreyasZare will want to try the PR.

@abdeldjalil-fellah
Copy link

abdeldjalil-fellah commented Nov 10, 2024

It works! tested on local machine with pebble:

local machine (technitium-dnsserver): 192.168.43.215
pebble machine: 192.168.43.201
note: the ca.pem that generates cert.pem should be added to system trust store

image

image

image

image

image

@ldez ldez marked this pull request as ready for review November 10, 2024 12:05
@ldez ldez removed the state/need-user-tests Need users to test functionality label Nov 10, 2024
@ldez ldez added this to the v4.20 milestone Nov 10, 2024
@ldez ldez requested a review from dmke November 10, 2024 12:06
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo, otherwise LGTM

providers/dns/technitium/technitium.toml Outdated Show resolved Hide resolved
ldez and others added 2 commits November 10, 2024 17:12
Co-authored-by: Dominik Menke <git@dmke.org>
@ldez ldez enabled auto-merge (squash) November 10, 2024 16:17
@ldez ldez merged commit 4efd1e1 into go-acme:master Nov 10, 2024
7 checks passed
@ldez ldez deleted the feat/technitium branch November 10, 2024 16:27
usarise added a commit to usarise/lego that referenced this pull request Nov 12, 2024
* volcengine: set API information within the default configuration (go-acme#2308)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

* limacity: fix error message (go-acme#2310)

* Add DNS provider for Core-Networks (go-acme#2101)

* chore: update readme generator (go-acme#2311)

* chore: fix readme generator (go-acme#2312)

* chore: embed templates for internal commands (go-acme#2314)

* chore: improve internal release command (go-acme#2315)

* fix: parse printf verbs in log line output (go-acme#2317)

* Add DNS provider for Regfish (go-acme#2320)

* chore: update dependencies (go-acme#2321)

* selectelv2: fix non-ASCII domain (go-acme#2322)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

* brandit: provider deprecation (go-acme#2116)

* cloudxns: provider deprecation (go-acme#2324)

* chore: update issue templates

* docs: use homogenous examples (go-acme#2328)

* regru: update authentication method (go-acme#2325)

* rfc2136: add support for tsig-keygen generated file (go-acme#2330)

Co-authored-by: Dominik Menke <git@dmke.org>

* Add DNS provider for Technitium (go-acme#2332)

* feat: skip the TLS verification of the ACME server (go-acme#2335)

* docs: add documentation for env var only options (go-acme#2337)

* docs: update least privilege instructions for Cloudflare (go-acme#2339)

* feat: attempt to check ARI unless explicitly disabled (go-acme#2298)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

* chore: domain merge simplification (go-acme#2340)

* chore: update linter (go-acme#2341)

* Prepare release v4.20.0

* Detach v4.20.0

* Prepare release v4.20.1

* Detach v4.20.1

* Prepare release v4.20.2

* Detach v4.20.2

* fix: HTTP server IPv6 matching (go-acme#2345)

* docs: improve changelog style (go-acme#2346)

* docs: fix typos

---------

Co-authored-by: 刘瑞斌 <bin@fit2cloud.com>
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
Co-authored-by: Dominik Menke <dom@digineo.de>
Co-authored-by: Frederic Hemberger <fhemberger@users.noreply.github.com>
Co-authored-by: Artem Chirkov <45077592+Archirk@users.noreply.github.com>
Co-authored-by: Maksim Kamanin <79706809+tcaty@users.noreply.github.com>
Co-authored-by: Dominik Menke <git@dmke.org>
Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
Co-authored-by: Samantha Frank <hello@entropy.cat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants