Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudxns: provider deprecation #2324

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 6, 2024

Fixes #2323

@ldez ldez added this to the v4.20 milestone Nov 6, 2024
@ldez ldez requested a review from dmke November 6, 2024 18:58
@ldez ldez force-pushed the fix/deprecate-cloudxns branch from c4ad554 to 73a75a6 Compare November 6, 2024 19:09
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I propose a more radical approach where cloudxns will be reduced to something like

// keep consts, type Config, and type DNSProvider

var ErrDeadProvider = errors.New("cloudxns: provider has shut down")

func NewDNSProvider() (*DNSProvider, error) {
    return nil, ErrDeadProvider
}

func NewDNSProviderConfig(*Config) (*DNSProvider, error) {
    return nil, ErrDeadProvider
}

func (d *DNSProvider) Present(string, string, string) error {
    return ErrDeadProvider
}

func (d *DNSProvider) CleanUp(string, string, string) error {
    return ErrDeadProvider
}

When their website/domain is already offline, I don't see why we need to keep any code for it.

This way, users get an early and explicit reason ("provider has shut down" vs. "Get : context deadline exceeded")

@ldez ldez force-pushed the fix/deprecate-cloudxns branch from 94e3073 to 7012b38 Compare November 6, 2024 22:18
providers/dns/cloudxns/cloudxns.go Outdated Show resolved Hide resolved
@ldez ldez enabled auto-merge (squash) November 6, 2024 22:37
@ldez ldez merged commit 67230e2 into go-acme:master Nov 6, 2024
7 checks passed
@ldez ldez deleted the fix/deprecate-cloudxns branch November 6, 2024 22:58
usarise added a commit to usarise/lego that referenced this pull request Nov 12, 2024
* volcengine: set API information within the default configuration (go-acme#2308)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

* limacity: fix error message (go-acme#2310)

* Add DNS provider for Core-Networks (go-acme#2101)

* chore: update readme generator (go-acme#2311)

* chore: fix readme generator (go-acme#2312)

* chore: embed templates for internal commands (go-acme#2314)

* chore: improve internal release command (go-acme#2315)

* fix: parse printf verbs in log line output (go-acme#2317)

* Add DNS provider for Regfish (go-acme#2320)

* chore: update dependencies (go-acme#2321)

* selectelv2: fix non-ASCII domain (go-acme#2322)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

* brandit: provider deprecation (go-acme#2116)

* cloudxns: provider deprecation (go-acme#2324)

* chore: update issue templates

* docs: use homogenous examples (go-acme#2328)

* regru: update authentication method (go-acme#2325)

* rfc2136: add support for tsig-keygen generated file (go-acme#2330)

Co-authored-by: Dominik Menke <git@dmke.org>

* Add DNS provider for Technitium (go-acme#2332)

* feat: skip the TLS verification of the ACME server (go-acme#2335)

* docs: add documentation for env var only options (go-acme#2337)

* docs: update least privilege instructions for Cloudflare (go-acme#2339)

* feat: attempt to check ARI unless explicitly disabled (go-acme#2298)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

* chore: domain merge simplification (go-acme#2340)

* chore: update linter (go-acme#2341)

* Prepare release v4.20.0

* Detach v4.20.0

* Prepare release v4.20.1

* Detach v4.20.1

* Prepare release v4.20.2

* Detach v4.20.2

* fix: HTTP server IPv6 matching (go-acme#2345)

* docs: improve changelog style (go-acme#2346)

* docs: fix typos

---------

Co-authored-by: 刘瑞斌 <bin@fit2cloud.com>
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
Co-authored-by: Dominik Menke <dom@digineo.de>
Co-authored-by: Frederic Hemberger <fhemberger@users.noreply.github.com>
Co-authored-by: Artem Chirkov <45077592+Archirk@users.noreply.github.com>
Co-authored-by: Maksim Kamanin <79706809+tcaty@users.noreply.github.com>
Co-authored-by: Dominik Menke <git@dmke.org>
Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
Co-authored-by: Samantha Frank <hello@entropy.cat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Remove CloudXNS DNS provider
2 participants