Skip to content
This repository has been archived by the owner on Feb 18, 2020. It is now read-only.

Feature/adding priv key wallet #384

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Oct 2, 2018

Private Key Wallet round 1... Fight!

  1. Allows user to enter Private Key and get a wallet created - right now it only works for localhost as it is hard-coded in - TODO: allow user to enter URL of infura node to connect to?
  2. changes API as singleton logic was preventing changing wallets (it would check oh is var filled? yes? ok fuck u then no change) - so now this is overridden by a boolean parameter on setup. This does present problems as changing wallets and clicking the same will always re-instantiate things. But this works and prevents reloading of API during setup.
  3. Creation of crude validateTransaction modal like MM does before signing. It sucks because, well it sucks, and mainly because it covers the informative modals telling users what's going on. Need to find a better solution.

@ghost
Copy link

ghost commented Oct 2, 2018

Travis automatic deployment:
https://pr384--dxreact.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Oct 2, 2018

Travis automatic deployment:
https://pr384--dxreact.review.gnosisdev.com

@ghost
Copy link

ghost commented Oct 15, 2018

Travis automatic deployment:
https://pr384--dxreact.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Oct 15, 2018

Travis automatic deployment:
https://pr384--dxreact.review.gnosisdev.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants