This repository has been archived by the owner on Feb 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Detailed Account + Wallet view && Change wallet #375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
W3stside
commented
Sep 26, 2018
- adds detailed Account view in MenuWallet
- adds ability to change wallet on click
Velenir
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can add Status and co. icons in the future
Velenir
pushed a commit
that referenced
this pull request
Oct 2, 2018
* Declare secure environment variables in Travis configuration * re-added back logic to remove wallet locked banner if unlocked mid app polling (#374) * Added ability change wallets + show account/wallet (#375) * added back in missing Status icons for wallet * Configure PR deployments * Execute travis in specific cases * Configure production deployment * Dx 589/fix weth using rinkeby address (#376) * create selector to look for tokens in tokenList * add WETH template, sans address * make swapTokensInAPair aware of the current WETH token * use new and improved swapTokensInAPair in reducer * add title display on symbol hover in TokenItem * Disable development builds when a tag is present * Add public dir with google console validation html page * Fix wrong network (#381) * Disable development builds when a tag is present * wait for window loaded before getting networkId * Misc fixes (#382) * remove repeated code block * properly import svg icons
W3stside
added a commit
that referenced
this pull request
Oct 8, 2018
W3stside
pushed a commit
that referenced
this pull request
Oct 9, 2018
* Declare secure environment variables in Travis configuration * re-added back logic to remove wallet locked banner if unlocked mid app polling (#374) * Added ability change wallets + show account/wallet (#375) * added back in missing Status icons for wallet * init commit for slow.trade rebranding * remove static prop blue on home button * add back static prop blue on home button * fix spinner fixed position * fix positioning of auction container and footer * contentpage style + content updates * mobile style updates * misc changes * misc changes * passed in network to menuWallet * misc changes * misc changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * no blue class TextSquare buttonCTA * removed comments/cleanup/ min-height menuauction scss fix
W3stside
added a commit
that referenced
this pull request
Oct 9, 2018
* Declare secure environment variables in Travis configuration * re-added back logic to remove wallet locked banner if unlocked mid app polling (#374) * Added ability change wallets + show account/wallet (#375) * added back in missing Status icons for wallet * init commit for slow.trade rebranding * remove static prop blue on home button * add back static prop blue on home button * fix spinner fixed position * fix positioning of auction container and footer * contentpage style + content updates * mobile style updates * misc changes * misc changes * passed in network to menuWallet * misc changes * misc changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * misc mobile responsive changes * no blue class TextSquare buttonCTA * made testing prod vs dev easier in local * fixed MenuAuctions 1. changed JS to match solidity math rules 2. added bothTheoClosed var to point state when 2 tokn pairs theo closed * removed comments/cleanup/ min-height menuauction scss fix * shortneded logic for outstandingvolume * fixed Auction Logic * uninstalled unused packages + created test ENV var 1. FE_CONDITIONAL_ENV used to test prod locally w/o build 2. removed await import as unused * passed in FE_CONDITIONAL_ENV var + cleanup * update p-lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.