Skip to content
This repository has been archived by the owner on Feb 18, 2020. It is now read-only.

Fix wrong network #381

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Fix wrong network #381

merged 2 commits into from
Oct 1, 2018

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Oct 1, 2018

Sometimes on reload web3 is injected but .version.network not yet set
Wait for window.onload before checking

@Velenir Velenir requested a review from W3stside October 1, 2018 12:56
@W3stside
Copy link
Contributor

W3stside commented Oct 1, 2018

nice one

@W3stside W3stside changed the base branch from develop to hotfix/1.0.5 October 1, 2018 12:57
@ghost
Copy link

ghost commented Oct 1, 2018

Travis automatic deployment:
https://pr381--dxreact.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Oct 1, 2018

Travis automatic deployment:
https://pr381--dxreact.review.gnosisdev.com

@W3stside W3stside added the 1.0.5 label Oct 1, 2018
@W3stside W3stside merged commit 930e4c5 into hotfix/1.0.5 Oct 1, 2018
@W3stside W3stside deleted the fix_late_networkId branch October 1, 2018 14:43
Velenir pushed a commit that referenced this pull request Oct 2, 2018
* Declare secure environment variables in Travis configuration

* re-added back logic to remove wallet locked banner if unlocked mid app polling (#374)

* Added ability change wallets + show account/wallet (#375)

* added back in missing Status icons for wallet

* Configure PR deployments

* Execute travis in specific cases

* Configure production deployment

* Dx 589/fix weth using rinkeby address (#376)

* create selector to look for tokens in tokenList

* add WETH template, sans address

* make swapTokensInAPair aware of the current WETH token

* use new and improved swapTokensInAPair in reducer

* add title display on symbol hover in TokenItem

* Disable development builds when a tag is present

* Add public dir with google console validation html page

* Fix wrong network (#381)

* Disable development builds when a tag is present

* wait for window loaded before getting networkId

* Misc fixes (#382)

* remove repeated code block

* properly import svg icons
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants