Zoom on notebook even if there is only one terminal in the tab + keep tab position and label in notebook rotation #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When there are multiple tabs, the notebook top bar is visible.
Now, it is possible to split the terminal and then zoom/maximize, so that the top bar is hidden.
But when there is only one terminal in the notebook tab, it's not possible to do it.
Solution
I added the signals for the notebook, so that it does zoom/maximize now.
Current bug
When unzooming a tab with a single terminal in it, the tab is moved to the end of the notebook.
I currently have no idea why it does that, but since it can be annoying I think it's best to fix it before merging.
Second commit
The function I deleted in the second commit (container.py) seems to be unused. Nowhere it's called and other functions do the same thing.