Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resets the tab title on rotation #624

Closed
1 task done
WhiteBlackGoose opened this issue Jul 23, 2022 · 4 comments
Closed
1 task done

Resets the tab title on rotation #624

WhiteBlackGoose opened this issue Jul 23, 2022 · 4 comments
Assignees
@Vulcalien
Labels
bug Something isn't working

Comments

@WhiteBlackGoose
Copy link

  • Reproduces on terminator -u -g /dev/null

Describe the bug
Rotation of terminals resets the title of the current tab

To Reproduce

  1. Create more than one tab
  2. Rename it to something
  3. Rotate terminals
  4. It's back to the default one (it's /bin/bash in my case)

Expected behavior
Should keep the title

Desktop (please complete the following information):

  • Xubuntu
  • 22.04
  • X11

Additional context
terminator 2.1.1
@mattrose mattrose added the bug Something isn't working label Aug 18, 2022
@mattrose
Copy link
Member

Able to reproduce

@Vulcalien
Copy link
Member

In #589 I dealt with what seems to be the same issue. That code should be easily adapted to fix this as well.

@Vulcalien Vulcalien self-assigned this Aug 27, 2022
@Vulcalien
Copy link
Member

Ok should be working! I put the fix in #589 since it uses similar code

@Vulcalien
Copy link
Member

I tested it, and after #589 it doesn't happen anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vulcalien Vulcalien

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattrose @WhiteBlackGoose @Vulcalien