-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Add new logo to readme #1087
🎨 Add new logo to readme #1087
Conversation
c1f5a2d
to
a3e1f77
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
=====================================
Coverage 87.3% 87.3%
=====================================
Files 102 102
Lines 5388 5388
Branches 997 997
=====================================
Hits 4704 4704
Misses 530 530
Partials 154 154 ☔ View full report in Codecov by Sentry. |
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.5.1 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Better aligned logo placement
Since it's a logo and not a banner, it should not go full size front and center. So I changed how it's rendered aligned with the rest of the text. At least in markdown to html. Inspiration for alignment here. |
Added some descriptive text to explain what one might use the library for. (this also improves alignment of text and images in the rendered document)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Follow up PR for #1083 since it is easier to get the correct link when the logo is already in the repo.
So check what the frontpage looks like you can look at this branch on my fork
Change summary
Checklist