🎨 Add new logo #1083

s-weigand · 2022-05-28T12:41:23Z

This adds the new logo discusses in #832 with the colored border being implemented via CSS instead of a base64 encoded image.

After we finalized decisions about the logos themself (colors, etc.), I will run docs/source/images/recreate_png_logos.py and create the png logos with the different resolutions.

Original logo design @SerLap
Original favicon design @jsnel

New logo in the docs

Change summary

Checklist

✔️ Passing the tests (mandatory for all PR's)
🚧 Added changes to changelog (mandatory for all PR's)
👌 Closes issue (mandatory for ✨ feature and 🩹 bug fix PR's)
📚 Adds documentation of the feature

Closes issues

closes #832

github-actions · 2022-05-28T12:41:34Z

👈 Launch a binder notebook on branch s-weigand/pyglotaran/new-logo

github-actions · 2022-05-28T12:45:19Z

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.5.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)


All benchmarks:

       before           after         ratio
     [96b42630]       [e5f7e6b2]
     <v0.5.1>                   
         68.8±1ms         69.7±1ms     1.01  BenchmarkOptimize.time_optimize(False, False, False)
         136±20ms         136±30ms     0.99  BenchmarkOptimize.time_optimize(False, False, True)
         69.6±2ms         70.8±2ms     1.02  BenchmarkOptimize.time_optimize(False, True, False)
         118±20ms         129±40ms     1.09  BenchmarkOptimize.time_optimize(False, True, True)
         85.9±2ms         90.1±2ms     1.05  BenchmarkOptimize.time_optimize(True, False, False)
        93.8±10ms         101±30ms     1.08  BenchmarkOptimize.time_optimize(True, False, True)
         88.0±4ms         85.4±3ms     0.97  BenchmarkOptimize.time_optimize(True, True, False)
         95.9±2ms         95.1±3ms     0.99  BenchmarkOptimize.time_optimize(True, True, True)
             200M             206M     1.03  IntegrationTwoDatasets.peakmem_optimize
       2.37±0.09s       2.07±0.05s    ~0.87  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)


All benchmarks:

       before           after         ratio
     [bc25e89e]       [e5f7e6b2]
         71.1±1ms         69.7±1ms     0.98  BenchmarkOptimize.time_optimize(False, False, False)
         125±40ms         136±30ms     1.09  BenchmarkOptimize.time_optimize(False, False, True)
         71.1±1ms         70.8±2ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
        90.0±40ms         129±40ms    ~1.43  BenchmarkOptimize.time_optimize(False, True, True)
         90.8±2ms         90.1±2ms     0.99  BenchmarkOptimize.time_optimize(True, False, False)
        99.5±30ms         101±30ms     1.02  BenchmarkOptimize.time_optimize(True, False, True)
         88.1±1ms         85.4±3ms     0.97  BenchmarkOptimize.time_optimize(True, True, False)
         127±40ms         95.1±3ms    ~0.75  BenchmarkOptimize.time_optimize(True, True, True)
             202M             206M     1.02  IntegrationTwoDatasets.peakmem_optimize
       2.08±0.07s       2.07±0.05s     1.00  IntegrationTwoDatasets.time_optimize

codecov · 2022-05-28T12:45:38Z

Codecov Report

Merging #1083 (bc25e89) into main (bc25e89) will not change coverage.
The diff coverage is n/a.

❗ Current head bc25e89 differs from pull request most recent head e5f7e6b. Consider uploading reports for the commit e5f7e6b to get more accurate results

@@          Coverage Diff          @@
##            main   #1083   +/-   ##
=====================================
  Coverage   87.3%   87.3%           
=====================================
  Files        102     102           
  Lines       5388    5388           
  Branches     997     997           
=====================================
  Hits        4704    4704           
  Misses       530     530           
  Partials     154     154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc25e89...e5f7e6b. Read the comment docs.

sourcery-ai · 2022-05-28T13:41:18Z

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	1.00 ⭐	1.00 ⭐	0.00
Method Length	279.00 ⛔	279.00 ⛔	0.00
Working memory	11.00 😞	11.00 😞	0.00
Quality	51.07% 🙂	51.07% 🙂	0.00%

Other metrics	Before	After	Change
Lines	303	303	0

Changed files	Quality Before	Quality After	Quality Change
docs/source/conf.py	51.07% 🙂	51.07% 🙂	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

ism200

fine with me
thanks

SerLap

what about such version for dark scheme

sonarqubecloud · 2022-06-05T15:43:35Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.7% Duplication

s-weigand · 2022-06-05T15:50:11Z

@SerLap I updated the color gradient for dark theme based on your comment and also changed the text and background colors to have a stronger contrast.
@jsnel and I decided to only use a text border for the transparent images since there readability is always a gamble depending on users having a light or dark theme.
For comparison of the transparent versions in light and dark themes:

SerLap · 2022-06-05T17:33:35Z

Looks ok to me

and font stroke color to the same color as font fill color

🧹 Renamed logos and favicons to dark/light theme 👌🎨 Changed dark and light colors to be the same as github dark theme for better contrast

sonarqubecloud · 2022-06-05T17:41:14Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.7% Duplication

jsnel

Looks good to me too! 🚀

s-weigand requested a review from ism200 May 28, 2022 12:41

s-weigand requested review from joernweissenborn, jsnel and SerLap May 28, 2022 12:41

s-weigand force-pushed the new-logo branch from 47609c0 to 64e4e5c Compare May 28, 2022 12:50

s-weigand changed the title ~~🎨 New logo~~ 🎨 Add new logo May 28, 2022

s-weigand force-pushed the new-logo branch from 8c1077f to e5fab1d Compare May 28, 2022 13:41

jsnel previously approved these changes May 28, 2022

View reviewed changes

ism200 previously approved these changes Jun 2, 2022

View reviewed changes

SerLap reviewed Jun 3, 2022

View reviewed changes

s-weigand dismissed stale reviews from ism200 and jsnel via c517c45 June 5, 2022 15:42

s-weigand force-pushed the new-logo branch from c517c45 to 9a0877d Compare June 5, 2022 15:42

jsnel removed the request for review from joernweissenborn June 5, 2022 17:32

s-weigand added 9 commits June 5, 2022 19:40

✨🎨 Added new logos

aa062f3

✨🎨 Added new favicons based on the new logos

5656bf6

🩹 Fixed mask alignement

2ae26ec

👌🎨 Changed used color to use nearly black and nearly white

65b6864

and font stroke color to the same color as font fill color

✨ Added script to render svg files to pgn with different sizes

b3f7637

📚🚧 Added change to changelog

73077a1

📚 Changed logo and favicon in docs

94966e0

👌🎨 Made background color gradient of dark theme icon darker

8602955

🧹 Renamed logos and favicons to dark/light theme 👌🎨 Changed dark and light colors to be the same as github dark theme for better contrast

🎨 Added rendered png versions of the icons

e5f7e6b

s-weigand force-pushed the new-logo branch from 9a0877d to e5f7e6b Compare June 5, 2022 17:40

jsnel self-requested a review June 5, 2022 17:41

jsnel approved these changes Jun 5, 2022

View reviewed changes

s-weigand merged commit cf859e9 into glotaran:main Jun 5, 2022

s-weigand deleted the new-logo branch June 5, 2022 18:32

s-weigand mentioned this pull request Jun 5, 2022

🎨 Add new logo to readme #1087

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎨 Add new logo #1083

🎨 Add new logo #1083

s-weigand commented May 28, 2022 •

edited

Loading

github-actions bot commented May 28, 2022

github-actions bot commented May 28, 2022 •

edited

Loading

codecov bot commented May 28, 2022 •

edited

Loading

sourcery-ai bot commented May 28, 2022 •

edited

Loading

ism200 left a comment

SerLap left a comment

sonarqubecloud bot commented Jun 5, 2022

s-weigand commented Jun 5, 2022 •

edited

Loading

SerLap commented Jun 5, 2022

sonarqubecloud bot commented Jun 5, 2022

jsnel left a comment

🎨 Add new logo #1083

🎨 Add new logo #1083

Conversation

s-weigand commented May 28, 2022 • edited Loading

Change summary

Checklist

Closes issues

github-actions bot commented May 28, 2022

github-actions bot commented May 28, 2022 • edited Loading

codecov bot commented May 28, 2022 • edited Loading

Codecov Report

sourcery-ai bot commented May 28, 2022 • edited Loading

Sourcery Code Quality Report

Legend and Explanation

ism200 left a comment

Choose a reason for hiding this comment

SerLap left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 5, 2022

s-weigand commented Jun 5, 2022 • edited Loading

SerLap commented Jun 5, 2022

sonarqubecloud bot commented Jun 5, 2022

jsnel left a comment

Choose a reason for hiding this comment

s-weigand commented May 28, 2022 •

edited

Loading

github-actions bot commented May 28, 2022 •

edited

Loading

codecov bot commented May 28, 2022 •

edited

Loading

sourcery-ai bot commented May 28, 2022 •

edited

Loading

s-weigand commented Jun 5, 2022 •

edited

Loading