K6 test for finding duplicates #6524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
force-pushed
the
feat.duplicates
branch
2 times, most recently
from
d4388ae to
60d052e
Compare
RubenGeo
force-pushed
the
feat.duplicates
branch
from
6fbd384 to
cf013f6
Compare
diderikvw
force-pushed
the
feat.duplicates
branch
from
cf013f6 to
ee14d58
Compare
Piotrk39
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
It looks good to me. The test correctly fails when triggered locally and this is very important. I also noticed that there are much more changes and tests then just k6 I browsed through those as well and I will trust you on those as well. Looks difficult. Good Job!!!
RubenGeo
force-pushed
the
feat.duplicates
branch
from
5402d3e to
a4bb9de
Compare
RubenGeo
force-pushed
the
test.duplicates-k6
branch
from
420ff08 to
19c1deb
Compare
RubenGeo
force-pushed
the
test.duplicates-k6
branch
from
19c1deb to
cc42fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#33539
Describe your changes
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.